More accurate package dependencies #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly speaking, libthemis depends on the OpenSSL library, not the "openssl" binary. The "openssl" package installs the entire binary along with its man pages, etc. Instead, it is sufficient to depend only on the library. The library package is typically called "libssl1.1", with an ABI suffix. The default OpenSSL library version differs between distros so we cannot write it in Makefile, but we should depend on the OpenSSL library from the particular distribution. If we were using debhelper, this would have been resolved for us automagically, but we are using FPM. Therefore we will use the dependencies of "libssl-dev" package as a proxy for the current default OpenSSL library name. This should be good enough.
Similar to Debian/Ubuntu situation, the "openssl" package on RHEL/CentOS installs the "openssl" binary. The package with libraries only is called "openssl-libs", we should depend on that instead. RPM packages typically do not include ABI infromation in the name, though the distros here typically do not ship multiple ABIs of a library either so it's fine.
ilammy
added
core
shadinua
approved these changes
Jul 20, 2020
Co-authored-by: Dmytro Shapovalov <[email protected]>
5 tasks
vixentael
approved these changes
Jul 21, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More accurate DEB dependencies
Strictly speaking,
libthemisdepends on the OpenSSL library, not theopensslbinary. Theopensslpackage installs the entire binary along with its man pages, etc. Instead, it is sufficient to depend only on the library.The library package is typically called
libssl1.1, with an ABI suffix. The default OpenSSL library version differs between distros so we cannot write it in Makefile, but we should depend on the OpenSSL library from the particular distribution. If we were using debhelper, this would have been resolved for us automagically, but we are using FPM. Therefore wewill use the dependencies of
libssl-devpackage as a proxy for the current default OpenSSL library name. This should be good enough.More accurate RPM dependencies
Similar to Debian/Ubuntu situation, the
opensslpackage on RHEL/CentOS installs theopensslbinary. The package with libraries only is calledopenssl-libs, we should depend on that instead.RPM packages typically do not include ABI information in the name, though the distros here typically do not ship multiple ABIs of a library either, so it's fine.
Checklist
Change is covered by automated tests(not really here, only on Buildbot)