Improve path-based build triggers #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to hysterical raisins, JavaThemis test suite is located in "tests/themis" directory (shared with Themis Core tests). Any changes there are triggering Test Core and WasmThemis test runs as well. Android test suite is heavy enough on its own, no need to make it run longer than necessary. Add an exclusion to do not trigger Themis Core and WasmThemis test suites when JavaThemis tests are modified. P.S. This change will nevertheless trigger a build because the build configurations for Themis Core and WasmThemis have changed. This should not be the case for future PRs.
vixentael
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to hysterical raisins, JavaThemis test suite is located in
tests/themisdirectory (shared with Themis Core tests). Any changes there are triggering Test Core and WasmThemis test runs as well.Android test suite is heavy enough on its own, no need to make it run longer than necessary.
Add an exclusion to do not trigger Themis Core and WasmThemis test suites when JavaThemis tests are modified.
P.S. This change will nevertheless trigger a build because the build configurations for Themis Core and WasmThemis have changed. This should not be the case for future PRs.
Checklist