Support Node.js v14 #654
Merged
Support Node.js v14 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version which is going to turn into LTS in October 2020. It's the current stable release. LTS is recommended for general use, but some packages already deliver the stable version (e.g., Homebrew). There are probably some deprecations that we need to take care of, but otherwise we can squeese this support claim into the release window for JsThemis 0.13 and WasmThemis 0.13.
ilammy
added
infrastructure
Sync up to pull in Emscripten changes.
shadinua
approved these changes
Jun 11, 2020
|
The only failing test is Android run on CircleCI which I'm going to ignore since it has nothing to do with the essence of this change. It kinda sucks to see it fail once in a while because apparently we can't have good things. It also kinda sucks to see Android tests run on each commit and each PR, even when no code changed that could affect Android. However, CircleCI does not have a convenient way to filter pipeline runs – or however it's called now – based on PR changes. There is a way to parse the diff yourself, but I'm not going to bother with this hack. I'm merging it red, deal with it 🕶️ |
Hack the planet 😈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version which is going to turn into LTS in October 2020. It's the current stable release. LTS is recommended for general use, but some packages already deliver the stable version (e.g., Homebrew).
There are probably some deprecations that we need to take care of, but otherwise we can squeese this support claim into the release window for JsThemis 0.13 and WasmThemis 0.13.
See https://nodejs.org/en/download/ for information on current Node.js releases.
Checklist