Pin Emscripten toolchain to 1.39.16-fastcomp #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Emscripten 1.39.17-fastcomp, the compiler is now printing
warnings, urging to migrate to the upstream flavor:
emcc: error: the fastomp compiler is deprecated. Please switch
to the upstream llvm backend as soon as possible and open issues
if you have trouble doing so [-Wfastcomp] [-Werror]
Unfortunately, we cannot migrate at the moment because the upstream
compiler is not able to build and link everything. While we're
investigating the issues, we need this warning gone -- we keep
a non-negotiable "treat warnings as errors" policy.
We cannot suppress this particular warning with "-Wno-fastcomp" because
it affects the BoringSSL build as well. They have "-Wall" added *after*
all custom flags so we are not able to suppress this warning there.
Therefore, for the time being, let's pin Emscripten toolchain to the
latest good version that does not emit warnings. I got the message,
I'll work on supporting the upstream flavor in the next release.
ilammy
added
infrastructure
shadinua
approved these changes
Jun 8, 2020
vixentael
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Emscripten 1.39.17-fastcomp, the compiler is now printing warnings, urging to migrate to the upstream flavor:
Unfortunately, we cannot migrate at the moment because the upstream compiler is not able to build and link everything. While we're investigating the issues, we need this warning gone – we keep a non-negotiable “treat warnings as errors” policy. This makes out builds red.
We cannot suppress this particular warning with
-Wno-fastcompbecause it affects the BoringSSL build as well. They have-Walladded after all custom flags so we are not able to suppress this warning there.Therefore, for the time being, let's pin Emscripten toolchain to the latest good version that does not emit warnings. I got the message, I'll work on supporting the upstream flavor in the next release.
Checklist
Changelog is updated(we'll keep a note it documentation)