Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 support #648

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Drop Python 2 support #648

merged 4 commits into from
Jun 2, 2020

Conversation

shadinua
Copy link
Contributor

@shadinua shadinua commented Jun 1, 2020

Python 2 had reached EOL on 2020-01-01.

In fact, we are not making any changes in this release that break compatibility, but we no longer officially support it. This means that we do not run any CI tests for Python 2, and free to develop code compatible only with Python 3+.

@shadinua shadinua added infrastructure Automated building and packaging tests Themis test suite compatibility Backward and forward compatibility, platform interoperability issues, breaking changes labels Jun 1, 2020
@shadinua shadinua self-assigned this Jun 1, 2020
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye python2

@@ -576,6 +577,10 @@ _Code:_
Existing master key API (`SCellSeal(key=...)`) should not be used with passphrases or passwords.
Use master key API with symmetric encryption keys, such as generated by `GenerateSymmetricKey()` ([#561](https://github.com/cossacklabs/themis/pull/561)).
Use passphrase API with human-readable passphrases.
- <a id="0.13.0-drop-python-2">Python 2 is no longer supported</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchors in changelog! Luxury life 😸

@vixentael
Copy link
Contributor

@shadinua
Copy link
Contributor Author

shadinua commented Jun 1, 2020

Yep, thanks, already saw it. Fixed.

Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shadinua shadinua merged commit e48d4c9 into master Jun 2, 2020
@shadinua shadinua deleted the shadinua/remove_python2 branch June 2, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Backward and forward compatibility, platform interoperability issues, breaking changes infrastructure Automated building and packaging tests Themis test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants