Make selectable languages in integration tests #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing on legacy OS we know in advance that some tests for unsupported modules will fail. We want to make the testing behaviour meet real expectations so it is convenient to have configurable set of modules to test. It was already implemented in the `tests_generator.py` script as environment variable `GENERATE_LANGUAGES`. In this commit: * the same behaviour was added to the `check_keygen.sh` script. * `GENERATE_LANGUAGES` was renamed to `THEMIS_TEST_LANGUAGES`
shadinua
added
infrastructure
ilammy
approved these changes
Jun 1, 2020
Comment on lines
+7
to
+9
| test_lang() { | ||
| [[ " $(echo "$THEMIS_TEST_LANGUAGES" | sed 's/,/ /g') " =~ " $1 " ]] | ||
| } |
There was a problem hiding this comment.
This is a bit tricky comparison but it works, so I'm okay with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing on legacy OS we know in advance that some tests for unsupported modules will fail. We want to make the testing behaviour meet real expectations so it is convenient to have configurable set of modules to test.
It was already implemented in the
tests_generator.pyscript as environment variableGENERATE_LANGUAGES.In this commit:
check_keygen.shscript.GENERATE_LANGUAGESwas renamed toTHEMIS_TEST_LANGUAGES