Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim official iPadOS support #641

Merged
merged 1 commit into from
May 25, 2020
Merged

Claim official iPadOS support #641

merged 1 commit into from
May 25, 2020

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented May 18, 2020

iPadOS is actually a flavor of iOS and have unofficially supported targeting iPads for quite a while (it technically worked). Check the “iPad” check boxes is Xcode projects and run half of the test suite on iPad simulators. Now we can claim with some confidence that we support iPads and commit to resolving issues with that platform if they arise.

Checklist

  • Change is covered by automated tests
  • The coding guidelines are followed
  • Example projects and code samples are up-to-date
  • Changelog is updated

iPadOS is actually a flavor of iOS and have unofficially supported
targeting iPads for quite a while (it technically worked). Check the
"iPad" check boxes is Xcode projects and run half of the test suite on
iPad simulators. Now we can claim with some confidence that we support
iPads and commit to resolving issues with that platform if they arise.
@ilammy ilammy added O-iOS 📱 Operating system: iOS W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API labels May 18, 2020
@ilammy
Copy link
Collaborator Author

ilammy commented May 18, 2020

I do not have an actual iPad available but @vixentael can provide a witness statement that ObjCThemis works there.

Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A year since introducing of iPadOS, and it's still unclear, if it's just a marketing name or does it have actual changes. Let's test!

@vixentael
Copy link
Contributor

@vixentael can provide a witness statement that ObjCThemis works there

"it just works"

@ilammy ilammy merged commit 66b6679 into cossacklabs:master May 25, 2020
@ilammy ilammy deleted the ipad branch May 25, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-iOS 📱 Operating system: iOS W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants