Build Themis as regular user #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f79cd23 ("configure" script for platform detection, 2020-03-27) keeps on giving! One side effect of performing configuration only once on the first run is that if you initially install Themis with sudo make install without running "make" first then "./configure" will be run as root too, meaning that it may not see some toolchains installed locally for the user, not globally in the system. Rust's rustup is an example of toolchain installer which does not install it's stuff into system *and* configures PATH in such way that its local installation is not visible from within sudo. This means that "sudo make install" wlll not see Rust toolchain and will write empty RUST_VERSION variable to "configuration.mk". This will cause "make test_rust" to do nothing and exit while printing a lovecraftian message during CI runs: fatal: No names found, cannot describe anything. tput: No value for $TERM and no -T specified make: Nothing to be done for 'test_rust'. (Other messages are unrelated, but funny nevertheless) So... Install Themis by doing make sudo make install to ensure that "./configure" sees Rust toolchain and the tests will actually get run. While we're here, update all other instances of Themis Core installation with bare "sudo make install" to avoid such issue if it becomes actual. However, most other toolchain installers seems to install their stuff globally so the above issue is not actual for them right now.
ilammy
added
infrastructure
Lagovas
approved these changes
Apr 24, 2020
shadinua
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #611 keeps on giving! One side effect of performing configuration only once on the first run is that if you initially install Themis with
without running
makefirst then./configurewill be run as root too, meaning that it may not see some toolchains installed locally for the user, not globally in the system.Rust's rustup is an example of toolchain installer which does not install it's stuff into system and configures PATH in such way that its local installation is not visible from within sudo.
This means that
sudo make installwill not see Rust toolchain and will write empty RUST_VERSION variable to configuration.mk. This will causemake test_rustto do nothing and exit while printing a lovecraftian message during CI runs:(Other messages are unrelated, but funny nevertheless)
So... Install Themis by doing
to ensure that
./configuresees Rust toolchain and the tests will actually get run.While we're here, update all other instances of Themis Core installation with bare
sudo make installto avoid such issue if it becomes actual. However, most other toolchain installers seems to install their stuff globally so the above issue is not actual for them right now.Checklist