Run long KDF tests of GitHub Actions #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f78d72c (Public PBKDF2 API, 2020-01-24) introduced KDF API as well as some long running tests which are normally not run, but CircleCI was given SOTER_KDF_RUN_LONG_TESTS variable to enable those tests. Use SOTER_KDF_RUN_LONG_TESTS in GitHub Actions too to exercise long KDF when running unit tests. Don't do it for "sanitizers" and "leak-check" jobs which are already running slow.
ilammy
added
core
Lagovas
approved these changes
Apr 24, 2020
vixentael
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #574 introduced KDF API as well as some long running tests which are normally not run, but CircleCI was given SOTER_KDF_RUN_LONG_TESTS variable to enable those tests.
Use SOTER_KDF_RUN_LONG_TESTS in GitHub Actions too to exercise long KDF when running unit tests. Don't do it for
sanitizersandleak-checkjobs which are already running slow.Checklist