-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and deprecate Themis 0.9.6 compatibility path #614
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7b500aa
Test for Themis 0.9.6 compatibility
ilammy 459b9e7
Cleanup Context Imprint compatibility code path
ilammy 5adcf33
Cleanup Context Imprint IV computation
ilammy b31cf33
Drop unused typedef themis_sym_message_hdr_t
ilammy 8a1781f
Remove SCELL_COMPAT define and ignore NO_SCELL_COMPAT variable
ilammy dfa33a5
Use compatibility path on 32-bit machines too
ilammy 545e782
Revert "Remove SCELL_COMPAT define and ignore NO_SCELL_COMPAT variable"
ilammy a6de319
Disable SCELL_COMPAT by default
ilammy 9676fda
Describe migration strategy in changelog
ilammy 39a4a1a
Test build WITH_SCELL_COMPAT on CircleCI
ilammy 0846314
Test build WITH_SCELL_COMPAT on GitHub Actions
ilammy ab34fa2
Move "error" label inside SCELL_COMPAT ifdef
ilammy 5631124
Merge branch 'master' into always-compat
ilammy 78ffd13
Merge branch 'master' into always-compat
ilammy 7932990
Reword changelog for clarity
ilammy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with "incorrect encryption algorithm" sentence. The issue was not about encryption algorithm, or params, it was about using wrong data type of storing length. We shouldn't make users think that encryption was bad/broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically if the algorithm says “use u32” and you're using u64, that's incorrect, but I agree with you that it can make an impression as if we'd been using DES by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue was not about AES algorithm, but in determining hmac length. That's not an algorithm issue, that's implementation issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant Secure Cell algorithm, as in whatever happens inside
themis_secure_cell_mode_encrypt()
. Well, given that the implementation is the spec and there is no paper that describes the entire algorithm in some language-agonstic way...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways, I've reworded that paragraph a bit to talk about “encrypted length computation” rather than “incorrect algorithm” and fixed some typos.