Use emcmake when building BoringSSL with Emscripten #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emscripten toolchain includes "emconfigure" tool which sets various
standard variables to setup crosscompilation. Since v1.14.1 Emscripten
include "emcmake" tool which is effectively emconfigure for CMake.
Themis can build embedded BoringSSL when it is selected as cryptographic
backend. With Emscriptedn we always use (and build) embedded BoringSSL.
For that we use "emconfigure cmake" to configure the build.
Since Emscripten v1.39.9 it is now mandatory to use "emcmake" for CMake
configuration, as it is evident from the following error message:
$ emmake make wasmthemis
make: make wasmthemis
building embedded BoringSSL...
error: use `emcmake` rather then `emconfigure` for cmake projects
make: *** [build/boringssl/crypto/libcrypto.a] Error 1
Use emmake if it is available, otherwise fall back to emconfigure when
building embedded BoringSSL with Emscripten.
ilammy
added
compatibility
Lagovas
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emscripten toolchain includes emconfigure tool which sets various standard variables to setup crosscompilation. Since v1.14.1 Emscripten includes emcmake tool which is effectively emconfigure for CMake.
Themis can build embedded BoringSSL when it is selected as cryptographic backend. With Emscripten we always use (and build) embedded BoringSSL. For that we use
emconfigure cmaketo configure the build.Since Emscripten v1.39.9 (released 3 days ago) it is now mandatory to use emcmake for CMake configuration, as evident from the following error message:
Use emmake if it is available, otherwise fall back to emconfigure when building embedded BoringSSL with Emscripten.
Interface for Themis users does not change: it's still simply
emmake make wasmthemisand we take care of all compatibility details.Checklist