Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct Secure Cell API in PHPThemis #601

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Use correct Secure Cell API in PHPThemis #601

merged 2 commits into from
Mar 5, 2020

Commits on Mar 2, 2020

  1. Use correct Secure Cell API in PHPThemis 

    It's not enough to name the function "with_passphrase" and accept
"passphrase" arguments. You also need to call Themis Core API that
uses passphrases.

PHP 5 calls the correct API but PHP 7 fell prey to a copy-paste mistake.
    @ilammy
    ilammy committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    39f820e View commit details
    Browse the repository at this point in the history

  2. Regression tests 

    Make sure this isssue does not happen again. Say, when we port PHPThemis
to PHP 7.4 using FFI module.
    @ilammy
    ilammy committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    82d61a9 View commit details
    Browse the repository at this point in the history