Explicitly disable Mac Catalyst support #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our targets declare that they support both iOS and iPadOS. Themis has never supported iPadOS explicitly, so disable all that stuff. Actually, instead of explicitly disabling, just set it to default (which will be iOS only). Recent versions of Xcode automatically enable "Mac Catalyst" -- support layer allowing to run iPadOS applications on macOS. This breaks build because OpenSSL and BoringSSL dependencies explicitly disable Catalyst. To be on the safe side, explicitly disable Catalyst for all our projects. We may enable it later, together with iPadOS support. All of this is currently invisible to Bitrise because it builds with older Xcode 10.2. However, macOS 10.14+ with Xcode 11.2 is affected by this when building from command line.
ilammy
added
O-iOS 📱
vixentael
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our targets declare that they support both iOS and iPadOS. Themis has never supported iPadOS explicitly, so disable all that stuff. Actually, instead of explicitly disabling, just set it to default (which will be iOS only).
Recent versions of Xcode automatically enable Mac Catalyst – support layer allowing to run iPadOS applications on macOS. This breaks build because OpenSSL and BoringSSL dependencies explicitly disable Catalyst. To be on the safe side, explicitly disable Catalyst for all our projects. We may enable it later, together with iPadOS support.
All of this is currently invisible to Bitrise because it builds with older Xcode 10.2. However, macOS 10.14+ with Xcode 11.2+ is affected by this when building from command line.
Checklist
Changelog is updated(nothing to note here, IMO)