Update links from github wiki to docserver #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenswry
requested review from
Lagovas,
shadinua and
vixentael
as code owners
ilammy
approved these changes
Feb 4, 2020
| | 🐹 Go | [Go Howto](https://github.com/cossacklabs/themis/wiki/Go-HowTo)| [docs/examples/go](https://github.com/cossacklabs/themis/tree/master/docs/examples/go) || | ||
| | 🦀 Rust | [Rust Howto](https://github.com/cossacklabs/themis/wiki/Rust-Howto)| [docs/examples/rust](https://github.com/cossacklabs/themis/wiki/Rust-Howto) | [](https://crates.io/crates/themis)| | ||
| | 🐹 Go | [Go Howto](https://docs.cossacklabs.com/pages/go-howto/)| [docs/examples/go](https://github.com/cossacklabs/themis/tree/master/docs/examples/go) || | ||
| | 🦀 Rust | [Rust Howto](https://docs.cossacklabs.com/pages/rust-howto/)| [docs/examples/rust](https://github.com/cossacklabs/themis/tree/master/docs/examples/rust) | [](https://crates.io/crates/themis)| |
There was a problem hiding this comment.
-[docs/examples/rust](https://github.com/cossacklabs/themis/wiki/Rust-Howto) +[docs/examples/rust](https://github.com/cossacklabs/themis/tree/master/docs/examples/rust)
Nice catch! 👍
| @@ -93,7 +93,7 @@ ifeq ($(NODE_VERSION),) | |||
| @echo 2>&1 "------------------------------------------------------------" | |||
| @echo 2>&1 "Node.js is not installed. Cannot run tests in Emscripten environment." | |||
| @echo 2>&1 "" | |||
| @echo 2>&1 "Please make sure you have \"node\" binary available in PATH and try again." | |||
| @echo 2>&1 "Make sure you have \"node\" binary available in PATH and try again." | |||
There was a problem hiding this comment.
Rude, but all the current style guides agree on "please" - that we should only use "please" when it's our fault and we're making the user go the extra mile to make things work due to an inconvenience/bug.
There was a problem hiding this comment.
Thanks, now I understand why.
vixentael
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in T1419 - replaced links to Wiki with links to Docserver where it was necessary + brushed up a few things in the repository's Readme.