Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme for iOS and Rust wrappers #581

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Update readme for iOS and Rust wrappers #581

merged 7 commits into from
Jan 28, 2020

Conversation

karenswry
Copy link
Contributor

Edited and expanded the Swift and Obj C example readmes according to https://ph.cossacklabs.com/T1430.

Note: The screenshots are the same as before, as pre-agreed. Once the more urgent tasks are out of the way, I'll change the screenshots, too.

vixentael
vixentael approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human-friendly docs are always a win! Thank you

@vixentael vixentael changed the title Karenswry reamde tasks Update readme for iOS and Rust wrappers Jan 27, 2020
@vixentael vixentael added docs 📚 Documentation, both offline and online W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API W-RustThemis 🦀 Wrapper: Rust-Themis, Rust API, Cargo crates W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API labels Jan 27, 2020
ilammy
ilammy reviewed Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some stray typos left, and I'd modernize the code style while we're here, but count me in 👍

I'll push the suggested changes into this branch.

@vixentael
Copy link
Contributor

Thanks for update @ilammy!

Please merge this PR to master when you're ready

@ilammy ilammy merged commit 8f158ba into master Jan 28, 2020
@ilammy ilammy deleted the karenswry-REAMDE-tasks branch January 28, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

@vixentael vixentael vixentael approved these changes

@Lagovas Lagovas Awaiting requested review from Lagovas Lagovas is a code owner

Assignees
No one assigned
Labels
docs 📚 Documentation, both offline and online W-ObjCThemis 🎨 Wrapper: ObjCThemis, Objective-C API W-RustThemis 🦀 Wrapper: Rust-Themis, Rust API, Cargo crates W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karenswry @vixentael @ilammy