Use "fastcomp" flavor of Emscripten #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have figured out that it's not the new version that's broken, it's the flavor. WasmThemis does not work well with the "upstream" flavor of Emscripten which is the default for "lastest" branch since 1.39. Instead of pinning an older version, use a suitable flavor. We'll be testing with "upstream" later once we figure out what's wrong with it.
ilammy
added
infrastructure
vixentael
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #550 rolled back Emscripten from
latestto1.38.48because then-latest1.39.0was broken.We have figured out that it's not the new version that's broken, it's the flavor. WasmThemis does not work well with the
upstreamflavor of Emscripten which is the default forlatestbranch since 1.39.Instead of pinning an older version, use a suitable flavor. We'll be testing with
upstreamlater once we figure out what's wrong with it.Checklist
Benchmark results are attachedExample projects and code samples are updatedChangelog is updated if needed(will consolidate if we fix upstream)