Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP Composer checksum #566

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented Dec 11, 2019

Yes, they made a new release. We should probably revisit our pinning approach with PHP Composer...

This should fix the Circle CI builds which are currently broken.

See #360 for previous updates.

Checklist

  • Change is covered by automated tests
  • Benchmark results are attached
  • The coding guidelines are followed
  • Public API has proper documentation
  • Example projects and code samples are updated
  • Changelog is updated

Yes, they made a new release. We should probably revisit our pinning
approach with PHP Composer...
@ilammy ilammy added W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API infrastructure Automated building and packaging labels Dec 11, 2019
@vixentael
Copy link
Contributor

At least we notice PHP composer updates :)

But I agree, it would be more beneficial to use less stressful approach

@vixentael vixentael merged commit a3abce4 into cossacklabs:master Dec 12, 2019
@vixentael vixentael deleted the php-composer-sha branch December 12, 2019 09:37
ilammy added a commit that referenced this pull request Dec 16, 2019
Yes, they made a new release. We should probably revisit our pinning
approach with PHP Composer...

(cherry picked from commit a3abce4)

This isn't really *needed* in this branch, but... it is because PHP
build needs this to be working, so we pull this and the next commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Automated building and packaging W-PHPThemis 🐘 Wrapper: PHPThemis, PHP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants