Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar and formatting changes #558

Merged
merged 17 commits into from
Nov 29, 2019
Merged

Grammar and formatting changes #558

merged 17 commits into from
Nov 29, 2019

Conversation

karenswry
Copy link
Contributor

Checklist

  • Change is covered by automated tests
  • Benchmark results are attached (if applicable)
  • The coding guidelines are followed
  • Public API has proper documentation
  • Example projects and code samples are updated if needed (in case of API changes)
  • Changelog is updated if needed (in case of notable or breaking changes)

ilammy
ilammy approved these changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

.github/ISSUE_TEMPLATE/feature_request.md Outdated Show resolved Hide resolved
docs/examples/README.MD Outdated Show resolved Hide resolved
docs/examples/README.MD Outdated Show resolved Hide resolved
docs/examples/rust/README.md Outdated Show resolved Hide resolved
@vixentael vixentael added the docs 📚 Documentation, both offline and online label Nov 28, 2019
vixentael
vixentael approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Agree with @ilammy comments. Let's fix-and-merge.

CONTRIBUTING.md Show resolved Hide resolved
docs/examples/rust/README.md Outdated Show resolved Hide resolved
Lagovas and others added 6 commits November 29, 2019 15:22
@vixentael vixentael merged commit c8a469f into master Nov 29, 2019
@vixentael vixentael deleted the karenswry-readmefixes-1 branch November 29, 2019 14:25
@vixentael
Copy link
Contributor

Merging these changes, as these are only docs changes.

jsthemis tests start failing, dunno why, but we'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@ilammy ilammy ilammy approved these changes

@Lagovas Lagovas Awaiting requested review from Lagovas Lagovas is a code owner

Assignees
No one assigned
Labels
docs 📚 Documentation, both offline and online
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karenswry @vixentael @ilammy @Lagovas