Don't suppress UBSan unless compiling with UBSan #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently added SOTER_ED25519_NO_UBSAN macro is expanded into UBSan tweaks even when we do not compile with Undefined Behavior sanitizer enabled. This can produce ugly warnings on systems that do not support all of the sanitizer flags. Let's just expand this macro into a no-op if we are not compiling with sanitizers. That's easier that deducing exactly which sanitizer flags are supported to avoid compiler warnings.
ilammy
requested review from
Lagovas,
shadinua,
storojs72 and
vixentael
as code owners
vixentael
approved these changes
Nov 9, 2019
ilammy
added a commit
to ilammy/themis
that referenced
this pull request
Nov 16, 2019
Recently added SOTER_ED25519_NO_UBSAN macro is expanded into UBSan tweaks even when we do not compile with Undefined Behavior sanitizer enabled. This can produce ugly warnings on systems that do not support all of the sanitizer flags. Let's just expand this macro into a no-op if we are not compiling with sanitizers. That's easier that deducing exactly which sanitizer flags are supported to avoid compiler warnings. (cherry picked from commit 61365d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently added SOTER_ED25519_NO_UBSAN macro is expanded into UBSan tweaks even when we do not compile with Undefined Behavior sanitizer enabled. This can produce ugly warnings on systems that do not support all of the sanitizer flags:
Let's just expand this macro into a no-op if we are not compiling with sanitizers. That's easier than deducing exactly which sanitizer flags are supported to avoid compiler warnings.
Checklist
Benchmark results are attached(not relevant)Public API has proper documentation(private changes)Example projects and code samples are updated(no API changes)Changelog is updated if needed(not interesting)