Fix Secure Comparator in PyThemis on 32-bit #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secure_comparator_get_result() returns themis_status_t which is defined as int32_t. We should expect 32-bit integer to be returned here. This kinda worked on 64-bit platforms because of how registers work on x86_64 and how 64-bit values are returned in System V ABI. However, this does not work on i686 and causes Python to see garbage returned.
ilammy
added
W-PyThemis 🐍
Lagovas
reviewed
Nov 9, 2019
|
Our internal CI system has been failing because of Python tests being broken on 32-bit systems due to this bug. (No links since that triggers @shadinua and @gene-eu, see T1393 you-know-where.) I've fired up a Debian Stretch i686 VM, installed Python, run the tests, and the failure immediately reproduced. Keen observation of the source file revealed the issue, and the fix worked on my machine. It also seems to fix the CI build as well, see you-know-what again. |
vixentael
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using incorrect return type which breaks PyThemis on 32-bit systems. Let’s use correct type.
Checklist
Benchmark results are attached(not applicable)Example projects and code samples are updated(no API changes)