Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump themis iOS to 0.12.2, update podspec, update examples #539

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

vixentael
Copy link
Contributor

(as part of 0.12.0 release flow)

Due to problems with latest GRKOpenSSLFramework 2.19 release I've downgraded dependency to 2.18, pushed new themis.podspec and updated examples.

Unfortunately, 2.19 release doesn't have some symbols and causes failure of archiving Xcode app, see #538.

Good thing:

  • it's fixed

Bad thing:

  • this fix is temporary until GRKOpenSSLFramework is fixed
  • such cruel dependency linking might cause dependency linking failure for projects that use GRKOpenSSLFramework separately.

@vixentael vixentael added the O-iOS 📱 Operating system: iOS label Sep 26, 2019
@ilammy
Copy link
Collaborator

ilammy commented Sep 26, 2019

such cruel dependency linking might cause dependency linking failure for projects that use GRKOpenSSLFramework separately

Aren’t projects that use GRKOpenSSL independently going to fail to archive even without Themis if they are using the broken 1.0.2.19 version? I guess by pinning the version we ‘fix' the linkage issue for them as well.

Though, it’s still true that dependency resolution might fail if the pinned version is incompatible with other requirements imposed by the project or other dependencies.

Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it’s okay to leave Carthage examples using 0.12.1 since 0.12.2 is not any different for Carthage.

@vixentael vixentael merged commit 8c07b5b into master Sep 26, 2019
@vixentael vixentael deleted the upd-themis-ios-0-12-3 branch September 26, 2019 13:24
@vixentael
Copy link
Contributor Author

Aren’t projects that use GRKOpenSSL independently going to fail to archive even without Themis if they are using the broken 1.0.2.19 version?

Can't tell now, need investigation. From my first try (see T1326), looks like projects that link GRKOpenSSL directly are being archived ok, projects that use themis->GRKOpenSSL produce error during archiving.

@ilammy ilammy mentioned this pull request Mar 2, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-iOS 📱 Operating system: iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants