Cleanup Makefile #527
Merged
Cleanup Makefile #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set "ERROR" variable and do not use "err". Instead just call $(error) immediately.
Also remove most of the comments because they are self-explanatory.
Also, use a better way to specify the default goal for "make".
shadinua
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr:
make readableShuffle around various bits of the Makefile and group them up. This makes our 800-line Makefile a bit easier to navigate. This PR mostly moves stuff around and improves comments, but there are a couple of minor non-trivial changes:
errtarget is now gone. If the user specifies invalid crypto engine then make fails immediatelyalltarget is now set as default in a different wayCFLAGSwhen building on macOS (matters only for cross-compilation)