Package libraries to arch-specific directories #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's install libraries into the directories expected by Linux
distributions when we prepare packages.
Debian-based systems use "multiarch" approach with shared libraries
installed under "/usr/lib/${compiler-target-triple}". This allows
installation of libraries for multiple architectures simulataneously,
hence the name. GCC makes it easy to obtain the target triple.
CentOS uses Filesystem Hierarchy Standard (well, it *is* Red Hat)
which tells that packages should install libraries to "/usr/lib64"
on 64-bit systems and to "/usr/lib" on 32-bit ones. We support only
one 64-bit architecture on Linux machines so we can check for it.
With these changes tools like "pkg-config" should work automatically
because all libraries are installed to their expected places.
|
does this affect on compatibility for users that already have Themis installed? |
No, it does not. When upgrading Themis package 0.11 → 0.12 the package manager will remove the libraries from their old location and will put them into the new location. Both locations are in the search paths so any existing software using Themis will just find the libraries in their new locations. The old locations that we have been using are compatibility locations, and the new ones are canonical, proper locations. |
Update pkg-config templates to use actual "libdir" and "includedir" variables. Currently we expect them to be hardcoded and depend only on the prefix, but that's not the case right now. Use the values used by Makefile when installing. Now pkg-config files will have correct paths when building multiarch packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's install libraries into the directories expected by Linux distributions when we prepare packages.
Debian-based systems use multiarch approach with shared libraries installed under
/usr/lib/${compiler-target-triple}. This allows installation of libraries for multiple architectures simultaneously, hence the name. GCC makes it easy to obtain the target triple.CentOS uses Filesystem Hierarchy Standard (well, it is Red Hat) which tells that packages should install libraries to
/usr/lib64on 64-bit systems and to/usr/libon 32-bit ones. We support only one 64-bit architecture on Linux machines so we can check for it.With these changes tools like pkg-config should work automatically because all libraries are installed to their expected places.