DEB & RPM packages for ThemisPP #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce DEB and RPM packages for ThemisPP. Since C++ is system language related to C, it's natural to provide our C++ wrapper as a system package. The wrapper requires Themis Core to be installed so this plays out nicely in the end. Alternatively, we can provide a package for various other package managers for C++ (such as Conan, vcpkg, CMake, Meson, and a zillion others) but there isn't much demand for that, and we'd have to provide Themis Core there as well for proper versioning and dependencies. So let's not complicate it more than necessary. Since ThemisPP is header-only we provide development packages: "libthemispp-dev" and "libthemispp-devel". There is no "libthemispp" package that's required at runtime: just "libthemis" is enough. While we're here, cleanup some name duplication in package names and dependencies.
ilammy
added
W-ThemisPP ⚔️
|
We will need to update Install documentation and to show users the easy way to install ThemisPP |
vixentael
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce DEB and RPM packages for ThemisPP. Since C++ is system language related to C, it's natural to provide our C++ wrapper as a system package. The wrapper requires Themis Core to be installed so this plays out nicely in the end.
Alternatively, we can provide a package for various other package managers for C++ (such as Conan, vcpkg, CMake, Meson, and a zillion others) but there isn't much demand for that, and we'd have to provide Themis Core there as well for proper versioning and dependencies. So let's not complicate it more than necessary.
Since ThemisPP is header-only we provide development packages:
libthemispp-devandlibthemispp-devel. There is nolibthemispppackage that's required at runtime: justlibthemisis enough.While we're here, cleanup some name duplication in package names and dependencies.
Packaging isn't tested by CircleCI. I have verified this manually on Ubuntu 16.04 and CentOS 7, but only @shadinua knows whether this will work with BuildBot.