Redundant key server pools #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using just "pool.sks-keyservers.net" as recommended by RVM documentation seems to be too unreliable for CI setup. It works fine for singular installations, but when deployed to CircleCI pool-selected servers are often unavailable, time out, and break our builds. Instead of using a single server try multiple ones for each key that we wish to request.
Lagovas
reviewed
Jul 22, 2019
| for key in 409B6B1796C275462A1703113804BB82D39DC0E3 \ | ||
| 7D2BAF1CF37B13E2069D6956105BD0E739499BDB | ||
| do | ||
| for server in pgp.mit.edu keyserver.pgp.com ha.pool.sks-keyservers.net |
There was a problem hiding this comment.
can you add a comment where you took these servers? for example some link like https://rvm.io/rvm/security
There was a problem hiding this comment.
Sure. That's exactly where I took them. I've added a comment.
This makes it easier to verify key IDs and update them as necessary if importing the keys or the signature checks that follow start failing.
vixentael
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RVM installation added in PR #503 requires PGP keys used by RVM to be available. We pull those from a public key server pool. However, using just "pool.sks-keyservers.net" as recommended by RVM documentation seems to be too unreliable for CI setup. It works fine for singular installations, but when deployed to CircleCI pool-selected servers are often unavailable, time out, and break our builds. Instead of using a single server try multiple ones for each key that we wish to request.