Fix Node.js 12 support #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8::Handle has been deprecated in favor of v8::Local since V8 4.5 and has been removed somehwere after V8 7.0. Node.js 12 (current stable) is upgrading V8 engine to 7.4+ which does not support v8::Handle. Mass-replace v8::Handle -> v8::Local to avoid that issue. It's supported even by the ancient Node versions packaged in older Ubuntu releases.
v8::Object::Set() and v8::FunctionTemplate::GetFunction() have had their API changed between V8 versions. Upgrading Node.js to 12 breaks them completely. Instead of using this API directly we should be using NAN helpers that encapsulate the changes and provide common API for Maybe types.
but can we add checks for different node versions to CircleCI later? or check them in BuildBot 🤔 |
vixentael
approved these changes
Jul 17, 2019
| // Prepare constructor template | ||
| v8::Local<v8::FunctionTemplate> tpl = Nan::New<v8::FunctionTemplate>(SecureCellContextImprint::New); | ||
| tpl->SetClassName(Nan::New("SecureCellContextImprint").ToLocalChecked()); | ||
| tpl->SetClassName(className); |
There was a problem hiding this comment.
good catch (here and below)
Sure thing. I'll add them, just in a separate PR. |
ilammy
added
W-JsThemis 🍭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest stable release of Node.js 12 includes updated V8 engine which has finally removed some of the deprecated API that we are using. JavaScript ecosystem has relatively low half-life periods for versions so we need to upgrade.
v8::Handlehas been deprecated in favor ofv8::Localsince V8 4.5 and has been removed somewhere after V8 7.0. Node.js 12 (current stable) is upgrading V8 engine to 7.4+ which does not support v8::Handle.Mass-replace v8::Handle → v8::Local to avoid that issue. It's supported even by the ancient Node versions packaged in older Ubuntu releases.
v8::Object::Set()andv8::FunctionTemplate::GetFunction()have had their API changed between V8 versions. Upgrading Node.js to 12 breaks them completely.Instead of using this API directly we should be using NAN helpers that encapsulate the changes and provide common API for Maybe types.
I have manually verified these changes with the following Node.js versions:
Currently CircleCI checks only Node.js v4. This PR does not update the build system so you'll have to trust me that it actually builds, for now.