Improved type safety tests #494
Merged
Commits on Jul 9, 2019
-
Combinatorial enumeration helper
Add a utility function which calls the provided closure for all possible combination of arguments from the provided arrays. This function allows testing multiple combinations of various invalid arguments and ensure that we don't miss any of them. Enjoy your dynamic typing experience.
-
Strict type checks in key generation functions
Add tests to verify that key generation functions do not accept any generally invalid arguments, such as "null", "undefined", etc. We accept only byte arrays. No strings, no integer arrays, no promises of arrays. Just Monika^W bytes.
-
-
Strict type checks in Secure Cell
Ensure that we disallow any unexpected types in Secure Cell input. There are a few exceptions from the generally invalid types: - Secure Cell accepts "null" values for context in Seal and Token Protect modes. But not for other arguments, and not in the Context Imprint mode. - Context Imprint mode has a custom error for "undefined" context value which is possible if the user omits the context argument (mistakingly assuming that it is optional) In all other cases we expect a TypeError to be thrown. -
Strict type checks in Secure Message
Ensure that we disallow any unexpected types in Secure Message input. The expectations are regular. However, in Secure Message constructor we produce Themis errors instead of TypeErrors.
-
Strict type checks in Secure Comparatore
Ensure that we disallow any unexpected types in Secure Comparator.
-
Strict type checks in Secure Session
Ensure that we disallow any unexpected types in Secure Session.
-
Keys cannot be constructed from empty strings
Actually, keys cannot be constructed from any string at the moment, but let's test this specifically because we rely on PrivateKey and PublicKey to contain valid non-empty keys at all times.
-
Replace clever hack with standard forEach loop
It turned out that I did not actually need that combinatorial hack so replace it with a more straightforward forEach loop. Well, that was a nice exercise.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.