WasmThemis utilities #489
Merged
WasmThemis utilities #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classical off-by-one mistake. We incorrectly reported error codes as 'undefined' when doing "new ThemisError(subsystem, errorCode)". This affects only human-readable description, not the 'errorCode' property, but it's very annoying for developers. Use ThemisError.describe only when there are 3 (three) or more arguments with human-readable error causes.
This function is going to be useful in multiple places for type checking of user byte arrays. Let's move it into a common utility module. While we're here, let it throw 'TypeError' instead of 'ThemisError' which should be more recognizable (and does not expect Themis "subsystem").
Quick! Unbreak Android builds right now!
vixentael
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out a couple of commits from #462 which contain common utilities. I'd like to have them in master before submitting pull requests for other cryptosystems support in WasmThemis. This should allow us to see only relevant code in those PR, without duplicating these two commits in all four PRs.