Improve error handling in soter_rand() #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of all, RAND_bytes() may return -1 if the backend does not support cryptographically strong pseudo-random generators. Currently we treat this as success which is not okay. Report the error properly. There's also a minor API mismatch between OpenSSL and BoringSSL. OpenSSL still mostly uses `int` for buffer lengths while BoringSSL has updated its API to use `size_t`. We need to check for possible overflow when using OpenSSL, and we do not need to cast anything with BoringSSL. Finally, while we're here, improve the documentation to clarify when SOTER_FAIL may be returned and what it means. Other error codes are more or less self-explanatory so we don't mention them.
vixentael
approved these changes
Jul 3, 2019
Lagovas
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, RAND_bytes() may return -1 if the backend does not support cryptographically strong pseudo-random generators. Currently we treat this as success which is not okay. Report the error properly.
There's also a minor API mismatch between OpenSSL and BoringSSL. OpenSSL still mostly uses
intfor buffer lengths while BoringSSL has updated its API to usesize_t. We need to check for possible overflow when using OpenSSL, and we do not need to cast anything with BoringSSL.Finally, while we're here, improve the documentation to clarify when SOTER_FAIL may be returned and what it means. Other error codes are more or less self-explanatory so we don't mention them.
Closes #477