Merging Themis Carthage changes, and minor docs update to master #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
requested review from
ilammy,
Lagovas,
ignatk and
storojs72
as code owners
ilammy
added a commit
to ilammy/themis
that referenced
this pull request
Sep 17, 2019
Previously, krzyzanowskim/OpenSSL 1.0.2.18 was broken and we were not even able to revert to 1.0.2.17 because Carthage mandates three-part semver-compatible versions of dependencies (though packages themselves can have more version parts). Since then Marcin has pushed an update to 1.0.2.18 which fixes the original linkage issue. It also introduces new versioning scheme (1.0.218) which allows reverting, just in case. We can go back to using "~> 1.0.2" as our dependency spec. Remove the workaround and update the lock file as well. You can read the whole backstory here: cossacklabs#483 cossacklabs#484 and in other pull requests and issues linked from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick changes from #483 (re-link Themis Carthage to
1.0.2.17OpenSSL), and add some minor docs updates.Regarding linkage – on next release I plan to switch Themis Carthage back to
~> 1.0.2notation.