Windows support in JsThemis #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update binding.gyp file for Windows. This allows users to install JsThemis on Windows provided that Themis Core is installed under "C:\Program Files\Themis". We expect MSYS2-based build of Themis Core to be installed there and use its naming convention and directory layout. Unfortunately, Windows does not have a notion of standard directories for development libraries and headers so we have to tell MSBuild exactly where to look for the library.
vixentael
approved these changes
May 22, 2019
ilammy
added
W-JsThemis 🍭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update binding.gyp file for Windows. This allows users to install JsThemis on Windows provided that Themis Core is installed under
C:\Program Files\Themis. We expect MSYS2-based build of Themis Core to be installed there and use its naming convention and directory layout. Unfortunately, Windows does not have a notion of standard directories for development libraries and headers so we have to tell MSBuild exactly where to look for the library.