Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve SecureMessage sign/verify examples for iOS #467

Merged
merged 2 commits into from
May 7, 2019
Merged

improve SecureMessage sign/verify examples for iOS #467

merged 2 commits into from
May 7, 2019

Conversation

vixentael
Copy link
Contributor

Based on #464 and #465 I've checked & refreshed iOS examples for SecureMessage in sign/verify mode, and tests.

  • swift iOS cocoapods
  • swift iOS carthage
  • swift macos carthage
  • objc iOS cocoapods
  • objc iOS carthage
  • objc macos carthage

@vixentael vixentael added O-iOS 📱 Operating system: iOS W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API labels May 6, 2019
@vixentael vixentael requested a review from ilammy May 6, 2019 16:42
@vixentael vixentael requested a review from Lagovas as a code owner May 6, 2019 16:42
Lagovas
Lagovas approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ilammy
ilammy approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

(I did not really mind copy-pasting all these tests across the iOS — macOS, Carthage — CocoaPods spectra initially... but now I start having doubts. Well, let's wait and see if we have to do more changes here.)

@vixentael vixentael merged commit 7fed185 into master May 7, 2019
@vixentael vixentael deleted the vxtl/T1176-ios-secure-message branch May 7, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilammy ilammy ilammy approved these changes

@Lagovas Lagovas Lagovas approved these changes

Assignees
No one assigned
Labels
O-iOS 📱 Operating system: iOS W-SwiftThemis 🔶 Wrapper: SwiftThemis, Swift API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vixentael @ilammy @Lagovas