Fix Clippy warnings #466
Merged
Fix Clippy warnings #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Clippy does not like when you write "|s| s.to_owned()" because making a new closure here is reduntant (you can pass the function std::borrow::ToOwned::to_owned there directly). This causes a warning and we treat warnings as errors. Anyway, it's not like we need to avoid this computation here with a closure so rewrite the code to compute the default path in a more straightforward way and thus avoid the wrath of our resident god of static analysis.
|
oh this world on modern development :) we shall merge this PR before #465 |
vixentael
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Clippy does not like when you write
|s| s.to_owned()because making a new closure here is reduntant (you can pass the function std::borrow::ToOwned::to_owned there directly). This causes a warning and we treat warnings as errors, which breaks the builds.Anyway, it's not like we need to avoid this computation here with a closure so rewrite the code to compute the default path in a more straightforward way and thus avoid the wrath of our resident god of static analysis.