Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "all" the default target again #459

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented Apr 12, 2019

Recent additions to included makefiles have changed the default target from all to something unexpected (Soter's static library, if you're lucky). Let's make sure that all is the default target—the first one in the Makefile—when users are simply running

make

Recent additions to included makefile have changed the default target
from "all" to something unexpected (Soter's static library, if you're
lucky). Let's make sure that "all" is the default target when users
are simply running "make".
@ilammy ilammy added the infrastructure Automated building and packaging label Apr 12, 2019
@ilammy ilammy requested a review from Lagovas April 12, 2019 15:10
Copy link
Contributor

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense why not

@vixentael vixentael added the installation Installation of Themis core and wrapper packages label Apr 12, 2019
@ilammy ilammy merged commit 2ff700c into master Apr 16, 2019
@ilammy ilammy deleted the ilammy/default-make-target branch April 16, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Automated building and packaging installation Installation of Themis core and wrapper packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants