Ignored NIST statistical tests with NO_NIST_STS #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, NIST STS requires access to genuine randomness source and
tends to fail in Docker environments where /dev/random is not accessible.
That's why we have an option to disable NIST STS by setting CIRICLE_TEST
(sic!) preprocessor variable.
Let's improve and cleanup this mechanism a bit.
- Use more obvious "NO_NIST_STS" environment variable instead of
fiddling with CFLAGS directly.
Admittedly, existing flag is more general as it allows to compile out
any code when building on CI. However, it has never been used for
anything other than NIST STS.
- Do not compile "assess" test runner if we're not going to use it
- Move NIST STS configuration to soter.mk
ilammy
added
infrastructure
|
@shadinua I don't know for sure, but I'm pretty much convinced that our internal CI system sneakily uses |
vixentael
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, NIST STS requires access to genuine randomness source and tends to fail in Docker environments where
/dev/randomis not accessible. That's why we have an option to disable NIST STS by setting CIRICLE_TEST (sic!) preprocessor variable.Let's improve and cleanup this mechanism a bit.
Use more obvious
NO_NIST_STSenvironment variable instead of fiddling with CFLAGS directlyAdmittedly, existing flag is more general as it allows to compile out any code when building on CI. However, it has never been used for anything other than NIST STS.
Do not compile "assess" test runner if we're not going to use it
Move NIST STS configuration to soter.mk