Use 'make install' for packaging #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilammy
added
infrastructure
shadinua
reviewed
Apr 15, 2019
Replace explicit 'file maps' for packaging with "make install" invocations. This ensures that we always package the same files that get installed when building from source. The list of files to be packaged is still maintained separately as we do split them into "libthemis" and "libthemis-dev" packages. Note that the split is not entirely correct: the static libraries and symbolic links should go into development package as well. However, for now we keep the old split for compatibility. We use the newly added DESTDIR capability to install into a temporary staging directory and then collect the files from there. Now we also no longer need to create symbolic links manually. However, stripping binaries still has to be performed, and we still need to construct pre- and postinstall scripts. Let's do it inline to save the trouble.
ilammy
force-pushed
the
ilammy/make-install-packages
branch
from
cbe1d8b
to
8697207
Compare
|
Finally, this is also ready for review. |
shadinua
approved these changes
Apr 16, 2019
|
Great work, thanks! |
vixentael
reviewed
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace explicit 'file maps' for packaging with
make installinvocations. This ensures that we always package the same files that get installed when building from source.The list of files to be packaged is still maintained separately as we do split them into "libthemis" and "libthemis-dev" packages. Note that the split is not entirely correct: the static libraries and symbolic links should go into development package as well. However, for now we keep the old split for compatibility.
We use the newly added DESTDIR capability to install into a temporary staging directory and then collect the files from there. Now we also no longer need to create symbolic links manually. However, stripping binaries still has to be performed, and we still need to construct pre- and postinstall scripts. Let's do it inline to save the trouble.