Optimize embedded BoringSSL build #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't build unnecessary libraries, binaries, tests, etc. Build only two
static libraries that we need. This results in considerable time saving
during the builds: BoringSSL contains quite a few tests and tools which
we do not run and use, yet they get built.
Native
------
Before:
$ time make all ENGINE=boringssl
real 4m36.341s
user 3m44.060s
sys 0m33.924s
After:
$ time make all ENGINE=boringssl
real 1m56.910s
user 1m29.960s
sys 0m19.392s
Nuff said.
Android
-------
Before:
$ time ./gradlew --no-daemon --no-parallel --max-workers=2 assembleDebug
real 34m46.028s
user 29m9.580s
sys 6m39.280s
After:
$ time ./gradlew --no-daemon --no-parallel --max-workers=2 assembleDebug
real 12m46.028s
user 9m1.880s
sys 2m52.020s
Admittedly, the difference may be smaller--as we still have to wait for
Gradle to download the whole Internet during Android build--but that's
still a significant improvement because there are four architectures
that we need to build BoringSSL for.
ilammy
added
O-Android 🤖
|
awesome, how you find it?) |
vixentael
approved these changes
Apr 2, 2019
|
Hm... Integration tests and x86_64 build fail on CircleCI at the moment because CircleCI builders seem to be throttled by Canonical's repositories and can't update all packages in time. I hope this is a transient issue. Anyway, I looked at Android build on CircleCI. I'll take it. |
Lagovas
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't build unnecessary libraries, binaries, tests, etc. Build only two static libraries that we need. This results in considerable time saving during the builds: BoringSSL contains quite a few tests and tools which we do not run and use, yet they get built.
Native
Before:
After:
Nuff said.
Android
Before:
After:
Admittedly, the difference may be smaller—as we still have to wait for Gradle to download the whole Internet during Android build—but that's still a significant improvement because there are four architectures that we need to build BoringSSL for.