Relax compatibility constraints #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially I thought that it would be good to pin "themis" to a particular version of "libthemis-sys" package (more stability and predictability, etc.) However, if you think about it, this strategy requires updating "themis" crate whenever there is patch update in "libthemis-sys" (ditto for "libthemis-sys" and "libthemis-src"). It may become a bother so I'd rather avoid it. We adhere to semver, therefore patch version updates should be compatible between minor versions. Relax the dependency constraints to allow patch updates between the crates.
vixentael
approved these changes
Mar 31, 2019
Lagovas
approved these changes
Apr 1, 2019
|
Android has some transient issues now. x86_64 build has checked Rust code so we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I thought that it would be good to pin
themisto a particular version oflibthemis-syspackage (more stability and predictability, etc.) However, if you think about it, this strategy requires updatingthemiscrate whenever there is patch update inlibthemis-sys(ditto forlibthemis-sysandlibthemis-src). It may become a bother so I'd rather avoid it.We adhere to semver, therefore patch version updates should be compatible between minor versions. Relax the dependency constraints to allow patch updates between the crates.