Fix pkg-config packaging on Linux #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "*_pkgconfig" targets to dependencies of "deb" and "rpm" targets, so that *.pc files are actually generated before they are packaged. Currently these are included only into "all" target which is not used during packaging. (However, it is used for "install" target.) Now the *.pc files will be included when only "make deb" or "make rpm" is run. Also, move the *.pc files into "libthemis-dev" and "libthemis-devel" packages, out from the "libthemis" package which should contain only (shared) libraries.
|
Also available as ilammy/pkg-config branch in the main fork. |
shadinua
approved these changes
Apr 1, 2019
|
Android builds on CircleCI have some transient issues with simulator version. Let's ignore it for now. Linux packages are not tested by CircleCI anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
*_pkgconfigtargets to dependencies ofdebandrpmtargets, so that *.pc files are actually generated before they are packaged. Currently these are included only intoalltarget which is not used during packaging. (However, it is used forinstalltarget.) Now the *.pc files will be included when onlymake debormake rpmis run.Also, move the *.pc files into
libthemis-devandlibthemis-develpackages, out from thelibthemispackage which should contain only (shared) libraries.