-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Carthage dependencies #430
Conversation
Use the upstream repository of OpenSSL instead of my private fork, now that Marcin has merged Carthage support into the mainline. Currently there is no suitable stable tag so pin a specific commit instead that is known to work. Update the lock-file as well so that we get correct versions after "carthage bootstrap".
Remove version specifiers in Carthage examples which means that we'll always use the latest stable (tagged) version. At the moment this is provisional 0.10.5 version, then it will be 0.11, and so on. Drop the lock files as well and add them into .gitignore. That way the users will recreate the lockfiles as necessary and won't commit them accidentally during development.
.gitignore
Outdated
@@ -64,6 +64,8 @@ docs/examples/Themis-server/swift/Pods | |||
docs/examples/Themis-server/Obj-C/Pods | |||
docs/examples/swift/Pods | |||
docs/examples/objc/Pods | |||
docs/examples/**/Carthage | |||
docs/examples/**/Cartfile.resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but cartfile.resolved is used to link to exact lib version, why not to push it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilammy up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and you've added these files to .gitignore, but they are pushed below 🤔
All good except ignoring Carthage files. Carthage best practices says do not ignore
https://github.com/Carthage/Carthage#for-both-platforms |
The idea here is to not specify exact version in example This is done only for examples. Themis itself still keeps the Which way do you prefer? Having the version pinned to examples, or having them automatically use the latest one? |
I think we should leave examples stick to the exact release tag, because in case of backwards compatibility changes, users won't be able to run examples, which is bad. It's better that we do some job during release to check that examples are working and to update 'em, than users will see not-working examples :) |
This reverts commit d75a5a7.
Okay then. I have reverted the commit that unpins the versions in examples. They will be updated in a separate PR after this one is merged and we know the commit that we need to pin examples to. |
CircleCI tests are not needed in this case, only Bitrise makes sense. |
Use the upstream repository of OpenSSL instead of my private fork, now that Marcin has merged Carthage support into the mainline.
Currently there is no suitable stable tag so pin a specific commit instead that is known to work.
Update the lock-file as well so that we get correct version after
carthage bootstrap
.Use the latest stable version in examplesEDIT: commit reverted, we'll still pin the version in examples.
Remove version specifiers in Carthage examples which means that we'll always use the latest stable (tagged) version. At the moment this is provisional 0.10.5 version, then it will be 0.11, and so on.
Drop the lock-files as well and add them into .gitignore. That way the users will recreate the lock-files as necessary and won't commit them accidentally during development.