Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Go Report fixes #426

Merged
merged 3 commits into from
Mar 12, 2019
Merged

Additional Go Report fixes #426

merged 3 commits into from
Mar 12, 2019

Conversation

ilammy
Copy link
Collaborator

@ilammy ilammy commented Mar 12, 2019

Some additional minor fixes in the tools directory (integration tools) which I missed.

@ilammy
go lint: use camelCase instead of snake_case
0c49112
@ilammy
go vet: fix error printing in tools
00576be 
We should use fmt.Fprintln() which actually accepts io.Writer as the
first argument, not fmt.Println() which always prints to stdout.
@ilammy
go fmt: reformat the code
a3a0583
@ilammy ilammy added the W-GoThemis 🐹 Wrapper: GoThemis, Go API label Mar 12, 2019
Lagovas
Lagovas approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ilammy ilammy merged commit f322b55 into cossacklabs:master Mar 12, 2019
@ilammy ilammy deleted the more-go-report-fixes branch March 12, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagovas Lagovas Lagovas approved these changes

@vixentael vixentael Awaiting requested review from vixentael vixentael is a code owner

Assignees
No one assigned
Labels
W-GoThemis 🐹 Wrapper: GoThemis, Go API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilammy @Lagovas