Remove deprecated Gothemis API (0.11) #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilammy
added
W-GoThemis 🐹
ilammy
force-pushed
the
remove-deprecated-gothemis-api-0.11
branch
2 times, most recently
from
b3a8ead
to
cf74e8c
Compare
Finally remove the incorrectly named API which was deprecated in 0.11.
ilammy
force-pushed
the
remove-deprecated-gothemis-api-0.11
branch
from
cf74e8c
to
8c871f6
Compare
|
What about to merge these changes only after updating code in Acra to use new names? https://github.com/cossacklabs/acra/blob/master/keystore/filesystem/server_keystore.go#L111 |
|
Uh... yeah. I thought everybody will automagically apply updates, but guess what! I don't like this PR to be dangling around (it's a bad idea in the hindsight) so I'll close it until we're really ready to remove the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we actually remove the API scheduled for deprecation since Themis 0.11: