Silent version checks #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silence output to stderr if there is no language support installed.
Most of the version checks already redirect stderr to /dev/null but some
of them merge stdout and stderr due to historical reasons. In this case
check whether a binary is available before trying to execute it.
This makes sure that "make" output does not contain unexpected messages
like
/bin/bash: python2 not found
/bin/bash: php not found
vixentael
approved these changes
Mar 6, 2019
shadinua
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence output to stderr if there is no language support installed. Most of the version checks already redirect stderr to /dev/null but some of them merge stdout and stderr due to historical reasons. In this case check whether a binary is available before trying to execute it.
This makes sure that "make" output does not contain unexpected messages like