Remove "cargo deadlinks" check #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have found this tool not *that* useful in preventing mistakes in API documentation, but it adds quite a considerable chunk to the build time of a development environment. I don't really want developers to wait 5-15 minutes to download and build all the dependencies just to have a check which passes 99% of time. We may reconsider this decision later if we actually run into issues with dead links in API docs.
ilammy
added
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this tool not that useful in preventing mistakes in API documentation, but it adds quite a considerable chunk to the build time of a development environment. I don't really want developers to wait 5-15 minutes to download and build all the dependencies just to have a check which passes 99.9999% of time.
We may reconsider this decision later if we actually run into issues with dead links in API docs.