Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Secure Message API in PyThemis #401

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Use new Secure Message API in PyThemis #401

merged 3 commits into from
Mar 4, 2019

Commits on Mar 1, 2019

  1. Use new Secure Message API in PyThemis 

    Straightforward changes to use new C API of Secure Message. We just
need to call different functions and that's it.

Keep Python method naming the same, we'll update it later separately.
    @ilammy
    ilammy committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    6374ac8 View commit details
    Browse the repository at this point in the history

  2. Improve key kind verification and tests 

    Previous implementation allowed to (ab)use SecureMessage class in
sign/verify mode by not specifying one of the keys. It is not possible
now since we're using the new C API. Now we require both public and
private key to be specified at Secure Message construction.

Update the tests to verify the new requirement and add more error
checking to constructor to ensure that both keys are provided and
that they have correct kinds.
    @ilammy
    ilammy committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    3e9c004 View commit details
    Browse the repository at this point in the history

  3. Early key kind checks for sign/verify mode 

    Check key kinds in sign/verify mode as well and produce user-friendly
error messages.

Update the tests to expect ThemisError now if the key is None.
Previously this failed on len() method call, now we check the type
correctly.
    @ilammy
    ilammy committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    fcd400c View commit details
    Browse the repository at this point in the history