Update tests for Themis iOS wrapper for new SecureMessage API #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
commented
Feb 28, 2019
| @@ -37,55 +37,105 @@ - (void)testGeneratingKeys { | |||
| } | |||
|
|
|||
| - (void)testSecureMessageEC256 { | |||
There was a problem hiding this comment.
real code changes in this file
vixentael
commented
Feb 28, 2019
| @@ -10,7 +10,6 @@ import XCTest | |||
| class SecureMessageTestsSwift: XCTestCase { | |||
|
|
|||
| func testExampleGeneratingKeys() { | |||
|
|
|||
There was a problem hiding this comment.
real code changes in this file
vixentael
commented
Feb 28, 2019
tests/objcthemis/Podfile
Outdated
| #pod 'themis', :git => "https://github.com/cossacklabs/themis.git" | ||
|
|
||
| # updated secure message API | ||
| pod 'themis', :git => "https://github.com/cossacklabs/themis.git", :branch => "vxtl/SM-ios" |
There was a problem hiding this comment.
will be changed to master on merge #393
vixentael
commented
Feb 28, 2019
| @@ -5,31 +5,31 @@ PODS: | |||
| - BoringSSL/Implementation (10.0.6): | |||
| - BoringSSL/Interface (= 10.0.6) | |||
| - BoringSSL/Interface (10.0.6) | |||
| - GRKOpenSSLFramework (1.0.2.14.1) | |||
ilammy
reviewed
Feb 28, 2019
| return [self wrapUnwrapWithPrivateKey:privateKeyData publicKey:publicKeyData]; | ||
| } | ||
|
|
||
| - (void)wrapUnwrapWithPrivateKey:(NSData *)privateKeyData publicKey:(NSData *)publicKeyData { | ||
| TSMessage *encrypter = [[TSMessage alloc] initInEncryptModeWithPrivateKey:privateKeyData peerPublicKey:publicKeyData]; | ||
|
|
||
| NSString *message = @"- Knock, knock.\n- Who’s there?\n*very long pause...*\n- Java."; |
ilammy
requested changes
Feb 28, 2019
ilammy
approved these changes
Feb 28, 2019
vixentael
changed the title
|
@ilammy thank you for pointing out copy-paste issues, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second PR for updating Themis iOS wrapper for new SecureMessage API (#389).
It contains updating Secure Message test project to include new checks.
It must be merged after merging PR #393 – then I'll relink example podspec to use code from master.