Additional safety checks for Secure Session (check if empty clientID) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that Secure Session breaks in a subtle and non-obvious way if it is created with empty client ID or missing private key. The user callbacks are also not thoroughly validated and may cause a crash if the user forgets to fill them in. Add checks for client ID and private key length as well as NULL checks for pointers involved with user context and its callbacks.
vixentael
approved these changes
Feb 19, 2019
| @@ -225,7 +245,13 @@ themis_status_t secure_session_connect(secure_session_t *session_ctx) | |||
|
|
|||
| if (THEMIS_SUCCESS == res) | |||
| { | |||
| ssize_t bytes_sent = session_ctx->user_callbacks->send_data(request, request_length, session_ctx->user_callbacks->user_data); | |||
| ssize_t bytes_sent = -1; | |||
There was a problem hiding this comment.
It means 'an error occurred'. send_data callback is expected to return a non-negative number of bytes that were transferred. It should be exactly the same as size_t request_length, anything else is considered an error. A negative value is guaranteed to be not equal to any non-negative number of bytes.
Lagovas
approved these changes
Feb 19, 2019
vixentael
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that Secure Session breaks in a subtle and non-obvious way if it is created with empty client ID or missing private key. The user callbacks are also not thoroughly validated and may cause a crash if the user forgets to fill them in.
Add checks for client ID and private key length as well as NULL checks for pointers involved with user context and its callbacks.