-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure Session example code #381
Conversation
Here is an example of using Secure Session to implement a minimal networking application. Don't do anything fancy: a simple echo server with fixed keys and basic error handling should be enough. We need to illustrate the following points: - how to initiate connections and exchange data - how to use both APIs of SecureSession - how to implement SecureSessionTransport correctly There are also some specific comments on the session termination which has to be handled on the application layer.
Please give this a look to ensure that I did not write anything stupid in comments and do not teach bad practices to the users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, although I'm not very good at reading rust code yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the current moment looks / feels good!
Here is an example of using Secure Session to implement a minimal networking application. Don't do anything fancy: a simple echo server with fixed keys and basic error handling should be enough.
We need to illustrate the following points:
There are also some specific comments on the session termination which has to be handled on the application layer.