Smart pointer constructors for Secure Session #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using legacy C++03 interface of Secure Session may be a bit hard with modern practices introduced by C++11. Let's provide a more idiomatic interface where Secure Session assumes ownership over the provided instance of "secure_session_callback_interface_t" via smart pointers. We do so using the shared_ptr instance. This allows both shared and unique ownership over the provided callback interface. For example, if the users need only get_public_key_for_id() interface then they can share an instance of secure_session_callback_interface_t between all Secure Sessions. However, if they need to use the transport interface (send_data/receive_data) then they are likely to provide a unique instance for each Secure Session. We keep the old non-owning constructor for backwards compatibility. However, we mark is deprecated to incite the users to move on to a more safe and idiomatic interface with smart pointers. We still need to test the old interface so silence the relevant warning in this file.
|
Let's wait for #379 to be merged and rerun the CI build with that. |
Lagovas
reviewed
Feb 14, 2019
| themispp::secure_session_t client_unique_moved = std::move(client_unique); | ||
|
|
||
| sput_fail_if(client_shared_moved.is_established(), "using shared session", __LINE__); | ||
| sput_fail_if(client_unique_moved.is_established(), "using unique session", __LINE__); |
There was a problem hiding this comment.
will be good to check that client_unique is invalid after move. check bad case too)
There was a problem hiding this comment.
Done. I've added a check that secure session throws after being moved out. (This is true for client_shared as well. Ownership over the transport does not matter here.)
vixentael
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using legacy C++03 interface of Secure Session may be a bit hard with modern practices introduced by C++11. Let's provide a more idiomatic interface where Secure Session assumes ownership over the provided instance of
secure_session_callback_interface_tvia smart pointers.We do so using the shared_ptr instance. This allows both shared and unique ownership over the provided callback interface. For example, if the users need only
get_public_key_for_idinterface then they can share an instance ofsecure_session_callback_interface_tbetween all Secure Sessions. However, if they need to use the transport interface (send_data/receive_data) then they are likely to provide a unique instance for each Secure Session.We keep the old non-owning constructor for backwards compatibility. However, we mark is deprecated to incite the users to move on to a more safe and idiomatic interface with smart pointers.
We still need to test the old interface so silence the relevant warning in this file.