Simplify transport usage in Secure Session (T963) #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using generics avoids type erasure for SecureSessionTransport impl. This has its efficiency merits but they are quite negligible given the amount of checks and marshalling that we perform. On the other hand, generics tend to "poison" the code with unnecessary "<T>"s which is not good for readability. Replace generics and static dispatch with a trait object and dynamic dispatch. Note that "user_context" in C still keeps a pointer to an intermediate Rust struct. We have to use a struct because it is not possible to cast "&mut dyn SecureSessionTransport" as "void*": trait objects are fat pointers in Rust. While we're here, rename "delegate" into "context" (it's not *only* delegate) and "session_ctx" into just "session" to avoid confusion. And really, mark unsafe functions as unsafe. They are used in unsafe blocks anyway.
Lagovas
approved these changes
Feb 11, 2019
vixentael
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using generics avoids type erasure for
SecureSessionTransportimpl. This has its efficiency merits but they are quite negligible given the amount of checks and marshaling that we perform. On the otherhand, generics tend to "poison" the code with unnecessary
<T>s which is not good for readability.Replace generics and static dispatch with a trait object and dynamic dispatch. Note that
user_contextin C still keeps a pointer to an intermediate Rust struct. We have to use a struct because it is not possible to cast&mut dyn SecureSessionTransportasvoid*: trait objects are fat pointers in Rust.While we're here, rename "delegate" into "context" (it's not only delegate) and "session_ctx" into just "session" to avoid confusion.
And really, mark unsafe functions as unsafe. They are used in unsafe blocks anyway.